fix: count only branches on added lines in diff coverage - #72
Merged
Conversation
Owner
Author
Coverage report
Click to see the coverage of changed files
Click to see whole project coverage
|
The pull request coverage percentage used the whole-file branch totals, so branches outside the diff dragged it down. Branch arcs are now selected by their source line and rendered as `source -> destination` instead of being grouped into line ranges, which never made sense for arcs.
ideepu
force-pushed
the
fix/branch-coverage-in-diff
branch
from
August 1, 2026 21:47
78c47cf to
1fd1369
Compare
ideepu
force-pushed
the
fix/branch-coverage-in-diff
branch
from
August 1, 2026 22:20
2163abf to
b3707f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select_diff_branches, and stored onFileDiffCoverage.fill_branch_missing_groups/_flatten_branches— arcs are not line ranges, so grouping them produced meaningless spans like[0, 11].source -> destination, withsource -> exitfor arcs leaving a scope (negative destination). Loop backward arcs normalize the link range.# pragma: no branch/ summary vs arc lists).Test plan
make lintmake test